Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with kwargs while calling subroutine #23

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

atharva-satpute
Copy link
Contributor

@atharva-satpute atharva-satpute commented May 31, 2024

Issue #11 :

Description of changes:

  • Convert kwargs to args to support keyword args while calling the subroutine function

Testing done: Yes

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atharva-satpute atharva-satpute requested a review from a team as a code owner May 31, 2024 19:52
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (32b2524) to head (1e5df3b).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         1903      1906    +3     
  Branches       320       320           
=========================================
+ Hits          1903      1906    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/unit_tests/autoqasm/test_api.py Outdated Show resolved Hide resolved
@atharva-satpute atharva-satpute force-pushed the fix-kwarg-subroutine branch 2 times, most recently from 1e053ce to 164635d Compare June 4, 2024 04:11
laurencap
laurencap previously approved these changes Jun 4, 2024
Copy link
Contributor

@jcjaskula-aws jcjaskula-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor change request. LGTM otherwise.

test/unit_tests/autoqasm/test_api.py Outdated Show resolved Hide resolved
@rmshaffer rmshaffer merged commit 90c2bbd into amazon-braket:main Jun 4, 2024
15 checks passed
@rmshaffer rmshaffer linked an issue Jun 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kwargs are not supported when calling an AutoQASM subroutine
4 participants